fix(secretsmanager): remove RequiresReplace for secretsmanager description#1495
Open
j1n-o9r wants to merge 2 commits into
Open
fix(secretsmanager): remove RequiresReplace for secretsmanager description#1495j1n-o9r wants to merge 2 commits into
j1n-o9r wants to merge 2 commits into
Conversation
2516be2 to
42f683f
Compare
42f683f to
b2a94ef
Compare
Merging this branch will not change overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Change in the secretsmanager description triggers unnecessary replacement of resource.
relates to STACKITTPR-649 and #882
Testing Instructions
Acceptance tests are currently blocked by STACKITSMA-1012, therefore you must test it manually:
run
terraform applyand approve -> the instance and the user should be created. Then change the user resource:run
terraform apply-> tf should suggest an inplace update for the user.Checklist
make fmtexamples/directory)make generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)